fix: 7.14.0 test hotfixes — blind-sign, Solana tx format, TRON structured#188
Open
BitHighlander wants to merge 2 commits intomasterfrom
Open
fix: 7.14.0 test hotfixes — blind-sign, Solana tx format, TRON structured#188BitHighlander wants to merge 2 commits intomasterfrom
BitHighlander wants to merge 2 commits intomasterfrom
Conversation
Blind-sign policy gating (AdvancedMode blocking) is 7.15+ scope. On 7.10-7.14 blind signing is always permitted. Remove test_ethereum_blind_sign_blocked which expected 7.15 firmware behavior and update report section V accordingly.
- Solana: prepend 0x00 signature count (compact-u16) to test tx builders — firmware parser expects full transaction format, not message-only - TRON: skip structured signing tests (transfer, trigger_smart) — firmware only supports raw_data blind-sign path in 7.14, structured deferred to 7.15+ - Update report section T to reflect TRON 7.14 scope (blind-sign only)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_ethereum_blind_sign_blocked— blind-sign policy gating deferred to 7.15+. On 7.10-7.14 blind signing is always permitted.0x00signature count (compact-u16) to test transaction builders. Firmware parser expects full transaction format[num_sigs][sigs][message], tests were sending message-only.test_tron_sign_transfer_structuredandtest_tron_sign_trc20_transfer— firmware only supportsraw_datablind-sign in 7.14, structured reconstruct-then-sign deferred to 7.15+.Supersedes #187.
Test plan